nintendo-back-up/Ryujinx
1
0
Fork 0
mirror of https://git.zaroz.cloud/nintendo-back-up/Ryujinx.git synced 2025-12-19 08:52:42 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

[Ryujinx.HLE] Address dotnet-format issues (#5380)

Browse Source 
* dotnet format style --severity info

Some changes were manually reverted.

* dotnet format analyzers --serverity info

Some changes have been minimally adapted.

* Restore a few unused methods and variables

* Silence dotnet format IDE0060 warnings

* Silence dotnet format IDE0052 warnings

* Address or silence dotnet format IDE1006 warnings

* Address dotnet format CA1816 warnings

* Address or silence dotnet format CA2208 warnings

* Address or silence dotnet format CA1806 and a few CA1854 warnings

* Address dotnet format CA2211 warnings

* Address dotnet format CA1822 warnings

* Address or silence dotnet format CA1069 warnings

* Make dotnet format succeed in style mode

* Address or silence dotnet format CA2211 warnings

* Address review comments

* Address dotnet format CA2208 warnings properly

* Make ProcessResult readonly

* Address most dotnet format whitespace warnings

* Apply dotnet format whitespace formatting

A few of them have been manually reverted and the corresponding warning was silenced

* Add previously silenced warnings back

I have no clue how these disappeared

* Revert formatting changes for while and for-loops

* Format if-blocks correctly

* Run dotnet format style after rebase

* Run dotnet format whitespace after rebase

* Run dotnet format style after rebase

* Run dotnet format analyzers after rebase

* Run dotnet format after rebase and remove unused usings

- analyzers
- style
- whitespace

* Disable 'prefer switch expression' rule

* Add comments to disabled warnings

* Fix a few disabled warnings

* Fix naming rule violation, Convert shader properties to auto-property and convert values to const

* Simplify properties and array initialization, Use const when possible, Remove trailing commas

* Start working on disabled warnings

* Fix and silence a few dotnet-format warnings again

* Run dotnet format after rebase

* Use using declaration instead of block syntax

* Address IDE0251 warnings

* Address a few disabled IDE0060 warnings

* Silence IDE0060 in .editorconfig

* Revert "Simplify properties and array initialization, Use const when possible, Remove trailing commas"

This reverts commit 9462e4136c0a2100dc28b20cf9542e06790aa67e.

* dotnet format whitespace after rebase

* First dotnet format pass

* Fix naming rule violations

* Fix typo

* Add trailing commas, use targeted new and use array initializer

* Fix build issues

* Fix remaining build issues

* Remove SuppressMessage for CA1069 where possible

* Address dotnet format issues

* Address formatting issues

Co-authored-by: Ac_K <acoustik666@gmail.com>

* Add GetHashCode implementation for RenderingSurfaceInfo

* Explicitly silence CA1822 for every affected method in Syscall

* Address formatting issues in Demangler.cs

* Address review feedback

Co-authored-by: Ac_K <acoustik666@gmail.com>

* Revert marking service methods as static

* Next dotnet format pass

* Address review feedback

---------

Co-authored-by: Ac_K <acoustik666@gmail.com>
This commit is contained in:
TSRBerry
2023-07-16 19:31:14 +02:00
committed by GitHub
parent fec8291c17
commit 326749498b
1015 changed files with 8173 additions and 7615 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/Ryujinx.HLE/HOS/Services/Loader/IDebugMonitorInterface.cs
View File

@@ -5,4 +5,4 @@
{
public IDebugMonitorInterface(ServiceCtx context) { }
}
}
}

2
src/Ryujinx.HLE/HOS/Services/Loader/IProcessManagerInterface.cs
View File

@@ -5,4 +5,4 @@
{
public IProcessManagerInterface(ServiceCtx context) { }
}
}
}

2
src/Ryujinx.HLE/HOS/Services/Loader/IShellInterface.cs
View File

@@ -5,4 +5,4 @@
{
public IShellInterface(ServiceCtx context) { }
}
}
}

69
src/Ryujinx.HLE/HOS/Services/Loader/ResultCode.cs
View File

@@ -1,43 +1,46 @@
namespace Ryujinx.HLE.HOS.Services.Loader
using System.Diagnostics.CodeAnalysis;
namespace Ryujinx.HLE.HOS.Services.Loader
{
[SuppressMessage("Design", "CA1069: Enums values should not be duplicated")]
enum ResultCode
{
ModuleId = 9,
ModuleId = 9,
ErrorCodeShift = 9,
Success = 0,
ArgsTooLong = (1 << ErrorCodeShift) | ModuleId,
MaximumProcessesLoaded = (2 << ErrorCodeShift) | ModuleId,
NPDMTooBig = (3 << ErrorCodeShift) | ModuleId,
InvalidNPDM = (4 << ErrorCodeShift) | ModuleId,
InvalidNSO = (5 << ErrorCodeShift) | ModuleId,
InvalidPath = (6 << ErrorCodeShift) | ModuleId,
AlreadyRegistered = (7 << ErrorCodeShift) | ModuleId,
TitleNotFound = (8 << ErrorCodeShift) | ModuleId,
ACI0TitleIdNotMatchingRangeInACID = (9 << ErrorCodeShift) | ModuleId,
InvalidVersionInNPDM = (10 << ErrorCodeShift) | ModuleId,
InsufficientAddressSpace = (51 << ErrorCodeShift) | ModuleId,
InsufficientNRO = (52 << ErrorCodeShift) | ModuleId,
InvalidNRR = (53 << ErrorCodeShift) | ModuleId,
InvalidSignature = (54 << ErrorCodeShift) | ModuleId,
InsufficientNRORegistrations = (55 << ErrorCodeShift) | ModuleId,
InsufficientNRRRegistrations = (56 << ErrorCodeShift) | ModuleId,
NROAlreadyLoaded = (57 << ErrorCodeShift) | ModuleId,
UnalignedNRRAddress = (81 << ErrorCodeShift) | ModuleId,
BadNRRSize = (82 << ErrorCodeShift) | ModuleId,
NRRNotLoaded = (84 << ErrorCodeShift) | ModuleId,
BadNRRAddress = (85 << ErrorCodeShift) | ModuleId,
BadInitialization = (87 << ErrorCodeShift) | ModuleId,
UnknownACI0Descriptor = (100 << ErrorCodeShift) | ModuleId,
ACI0NotMatchingKernelFlagsDescriptor = (103 << ErrorCodeShift) | ModuleId,
ACI0NotMatchingSyscallMaskDescriptor = (104 << ErrorCodeShift) | ModuleId,
ACI0NotMatchingMapIoOrNormalRangeDescriptor = (106 << ErrorCodeShift) | ModuleId,
ACI0NotMatchingMapNormalPageDescriptor = (107 << ErrorCodeShift) | ModuleId,
ACI0NotMatchingInterruptPairDescriptor = (111 << ErrorCodeShift) | ModuleId,
ACI0NotMatchingApplicationTypeDescriptor = (113 << ErrorCodeShift) | ModuleId,
ArgsTooLong = (1 << ErrorCodeShift) | ModuleId,
MaximumProcessesLoaded = (2 << ErrorCodeShift) | ModuleId,
NPDMTooBig = (3 << ErrorCodeShift) | ModuleId,
InvalidNPDM = (4 << ErrorCodeShift) | ModuleId,
InvalidNSO = (5 << ErrorCodeShift) | ModuleId,
InvalidPath = (6 << ErrorCodeShift) | ModuleId,
AlreadyRegistered = (7 << ErrorCodeShift) | ModuleId,
TitleNotFound = (8 << ErrorCodeShift) | ModuleId,
ACI0TitleIdNotMatchingRangeInACID = (9 << ErrorCodeShift) | ModuleId,
InvalidVersionInNPDM = (10 << ErrorCodeShift) | ModuleId,
InsufficientAddressSpace = (51 << ErrorCodeShift) | ModuleId,
InsufficientNRO = (52 << ErrorCodeShift) | ModuleId,
InvalidNRR = (53 << ErrorCodeShift) | ModuleId,
InvalidSignature = (54 << ErrorCodeShift) | ModuleId,
InsufficientNRORegistrations = (55 << ErrorCodeShift) | ModuleId,
InsufficientNRRRegistrations = (56 << ErrorCodeShift) | ModuleId,
NROAlreadyLoaded = (57 << ErrorCodeShift) | ModuleId,
UnalignedNRRAddress = (81 << ErrorCodeShift) | ModuleId,
BadNRRSize = (82 << ErrorCodeShift) | ModuleId,
NRRNotLoaded = (84 << ErrorCodeShift) | ModuleId,
BadNRRAddress = (85 << ErrorCodeShift) | ModuleId,
BadInitialization = (87 << ErrorCodeShift) | ModuleId,
UnknownACI0Descriptor = (100 << ErrorCodeShift) | ModuleId,
ACI0NotMatchingKernelFlagsDescriptor = (103 << ErrorCodeShift) | ModuleId,
ACI0NotMatchingSyscallMaskDescriptor = (104 << ErrorCodeShift) | ModuleId,
ACI0NotMatchingMapIoOrNormalRangeDescriptor = (106 << ErrorCodeShift) | ModuleId,
ACI0NotMatchingMapNormalPageDescriptor = (107 << ErrorCodeShift) | ModuleId,
ACI0NotMatchingInterruptPairDescriptor = (111 << ErrorCodeShift) | ModuleId,
ACI0NotMatchingApplicationTypeDescriptor = (113 << ErrorCodeShift) | ModuleId,
ACI0NotMatchingKernelReleaseVersionDescriptor = (114 << ErrorCodeShift) | ModuleId,
ACI0NotMatchingHandleTableSizeDescriptor = (115 << ErrorCodeShift) | ModuleId,
ACI0NotMatchingDebugFlagsDescriptor = (116 << ErrorCodeShift) | ModuleId
ACI0NotMatchingHandleTableSizeDescriptor = (115 << ErrorCodeShift) | ModuleId,
ACI0NotMatchingDebugFlagsDescriptor = (116 << ErrorCodeShift) | ModuleId,
}
}