[Ryujinx.HLE] Address dotnet-format issues (#5380)

* dotnet format style --severity info

Some changes were manually reverted.

* dotnet format analyzers --serverity info

Some changes have been minimally adapted.

* Restore a few unused methods and variables

* Silence dotnet format IDE0060 warnings

* Silence dotnet format IDE0052 warnings

* Address or silence dotnet format IDE1006 warnings

* Address dotnet format CA1816 warnings

* Address or silence dotnet format CA2208 warnings

* Address or silence dotnet format CA1806 and a few CA1854 warnings

* Address dotnet format CA2211 warnings

* Address dotnet format CA1822 warnings

* Address or silence dotnet format CA1069 warnings

* Make dotnet format succeed in style mode

* Address or silence dotnet format CA2211 warnings

* Address review comments

* Address dotnet format CA2208 warnings properly

* Make ProcessResult readonly

* Address most dotnet format whitespace warnings

* Apply dotnet format whitespace formatting

A few of them have been manually reverted and the corresponding warning was silenced

* Add previously silenced warnings back

I have no clue how these disappeared

* Revert formatting changes for while and for-loops

* Format if-blocks correctly

* Run dotnet format style after rebase

* Run dotnet format whitespace after rebase

* Run dotnet format style after rebase

* Run dotnet format analyzers after rebase

* Run dotnet format after rebase and remove unused usings

- analyzers
- style
- whitespace

* Disable 'prefer switch expression' rule

* Add comments to disabled warnings

* Fix a few disabled warnings

* Fix naming rule violation, Convert shader properties to auto-property and convert values to const

* Simplify properties and array initialization, Use const when possible, Remove trailing commas

* Start working on disabled warnings

* Fix and silence a few dotnet-format warnings again

* Run dotnet format after rebase

* Use using declaration instead of block syntax

* Address IDE0251 warnings

* Address a few disabled IDE0060 warnings

* Silence IDE0060 in .editorconfig

* Revert "Simplify properties and array initialization, Use const when possible, Remove trailing commas"

This reverts commit 9462e4136c0a2100dc28b20cf9542e06790aa67e.

* dotnet format whitespace after rebase

* First dotnet format pass

* Fix naming rule violations

* Fix typo

* Add trailing commas, use targeted new and use array initializer

* Fix build issues

* Fix remaining build issues

* Remove SuppressMessage for CA1069 where possible

* Address dotnet format issues

* Address formatting issues

Co-authored-by: Ac_K <acoustik666@gmail.com>

* Add GetHashCode implementation for RenderingSurfaceInfo

* Explicitly silence CA1822 for every affected method in Syscall

* Address formatting issues in Demangler.cs

* Address review feedback

Co-authored-by: Ac_K <acoustik666@gmail.com>

* Revert marking service methods as static

* Next dotnet format pass

* Address review feedback

---------

Co-authored-by: Ac_K <acoustik666@gmail.com>

src/Ryujinx.HLE/HOS/Services/Mii/StaticService/DatabaseServiceImpl.cs

@@ -6,9 +6,9 @@ namespace Ryujinx.HLE.HOS.Services.Mii.StaticService
 {
     class DatabaseServiceImpl : IDatabaseService
     {
-        private DatabaseImpl            _database;
-        private DatabaseSessionMetadata _metadata;
-        private bool                    _isSystem;
+        private readonly DatabaseImpl _database;
+        private readonly DatabaseSessionMetadata _metadata;
+        private readonly bool _isSystem;
 
         public DatabaseServiceImpl(DatabaseImpl database, bool isSystem, SpecialMiiKeyCode miiKeyCode)
         {

src/Ryujinx.HLE/HOS/Services/Mii/StaticService/IDatabaseService.cs

@@ -51,7 +51,7 @@ namespace Ryujinx.HLE.HOS.Services.Mii.StaticService
 
             ResultCode result = Get(flag, out int count, elementsSpan);
 
-            elementsSpan = elementsSpan.Slice(0, count);
+            elementsSpan = elementsSpan[..count];
 
             context.ResponseData.Write(count);
 
@@ -72,7 +72,7 @@ namespace Ryujinx.HLE.HOS.Services.Mii.StaticService
 
             ResultCode result = Get1(flag, out int count, elementsSpan);
 
-            elementsSpan = elementsSpan.Slice(0, count);
+            elementsSpan = elementsSpan[..count];
 
             context.ResponseData.Write(count);
 
@@ -85,8 +85,8 @@ namespace Ryujinx.HLE.HOS.Services.Mii.StaticService
         // UpdateLatest(nn::mii::CharInfo old_char_info, SourceFlag flag) -> nn::mii::CharInfo
         public ResultCode UpdateLatest(ServiceCtx context)
         {
-            CharInfo   oldCharInfo = context.RequestData.ReadStruct<CharInfo>();
-            SourceFlag flag        = (SourceFlag)context.RequestData.ReadInt32();
+            CharInfo oldCharInfo = context.RequestData.ReadStruct<CharInfo>();
+            SourceFlag flag = (SourceFlag)context.RequestData.ReadInt32();
 
             ResultCode result = UpdateLatest(oldCharInfo, flag, out CharInfo newCharInfo);
 
@@ -99,9 +99,9 @@ namespace Ryujinx.HLE.HOS.Services.Mii.StaticService
         // BuildRandom(Age age, Gender gender, Race race) -> nn::mii::CharInfo
         public ResultCode BuildRandom(ServiceCtx context)
         {
-            Age    age    = (Age)context.RequestData.ReadInt32();
+            Age age = (Age)context.RequestData.ReadInt32();
             Gender gender = (Gender)context.RequestData.ReadInt32();
-            Race   race   = (Race)context.RequestData.ReadInt32();
+            Race race = (Race)context.RequestData.ReadInt32();
 
             ResultCode result = BuildRandom(age, gender, race, out CharInfo charInfo);
 
@@ -135,7 +135,7 @@ namespace Ryujinx.HLE.HOS.Services.Mii.StaticService
 
             ResultCode result = Get2(flag, out int count, elementsSpan);
 
-            elementsSpan = elementsSpan.Slice(0, count);
+            elementsSpan = elementsSpan[..count];
 
             context.ResponseData.Write(count);
 
@@ -156,7 +156,7 @@ namespace Ryujinx.HLE.HOS.Services.Mii.StaticService
 
             ResultCode result = Get3(flag, out int count, elementsSpan);
 
-            elementsSpan = elementsSpan.Slice(0, count);
+            elementsSpan = elementsSpan[..count];
 
             context.ResponseData.Write(count);
 
@@ -169,8 +169,8 @@ namespace Ryujinx.HLE.HOS.Services.Mii.StaticService
         // UpdateLatest1(nn::mii::StoreData old_store_data, SourceFlag flag) -> nn::mii::StoreData
         public ResultCode UpdateLatest1(ServiceCtx context)
         {
-            StoreData  oldStoreData = context.RequestData.ReadStruct<StoreData>();
-            SourceFlag flag         = (SourceFlag)context.RequestData.ReadInt32();
+            StoreData oldStoreData = context.RequestData.ReadStruct<StoreData>();
+            SourceFlag flag = (SourceFlag)context.RequestData.ReadInt32();
 
             ResultCode result = UpdateLatest1(oldStoreData, flag, out StoreData newStoreData);
 
@@ -183,8 +183,8 @@ namespace Ryujinx.HLE.HOS.Services.Mii.StaticService
         // FindIndex(nn::mii::CreateId create_id, bool is_special) -> s32
         public ResultCode FindIndex(ServiceCtx context)
         {
-            CreateId createId  = context.RequestData.ReadStruct<CreateId>();
-            bool     isSpecial = context.RequestData.ReadBoolean();
+            CreateId createId = context.RequestData.ReadStruct<CreateId>();
+            bool isSpecial = context.RequestData.ReadBoolean();
 
             ResultCode result = FindIndex(createId, isSpecial, out int index);
 
@@ -198,7 +198,7 @@ namespace Ryujinx.HLE.HOS.Services.Mii.StaticService
         public ResultCode Move(ServiceCtx context)
         {
             CreateId createId = context.RequestData.ReadStruct<CreateId>();
-            int      newIndex = context.RequestData.ReadInt32();
+            int newIndex = context.RequestData.ReadInt32();
 
             return Move(createId, newIndex);
         }
@@ -358,12 +358,12 @@ namespace Ryujinx.HLE.HOS.Services.Mii.StaticService
             return new Span<byte>(rawData);
         }
 
-        private Span<T> CreateSpanFromBuffer<T>(ServiceCtx context, IpcBuffDesc ipcBuff, bool isOutput) where T: unmanaged
+        private Span<T> CreateSpanFromBuffer<T>(ServiceCtx context, IpcBuffDesc ipcBuff, bool isOutput) where T : unmanaged
         {
             return MemoryMarshal.Cast<byte, T>(CreateByteSpanFromBuffer(context, ipcBuff, isOutput));
         }
 
-        private void WriteSpanToBuffer<T>(ServiceCtx context, IpcBuffDesc ipcBuff, Span<T> span) where T: unmanaged
+        private void WriteSpanToBuffer<T>(ServiceCtx context, IpcBuffDesc ipcBuff, Span<T> span) where T : unmanaged
         {
             Span<byte> rawData = MemoryMarshal.Cast<T, byte>(span);