[Ryujinx.HLE] Address dotnet-format issues (#5380)

* dotnet format style --severity info

Some changes were manually reverted.

* dotnet format analyzers --serverity info

Some changes have been minimally adapted.

* Restore a few unused methods and variables

* Silence dotnet format IDE0060 warnings

* Silence dotnet format IDE0052 warnings

* Address or silence dotnet format IDE1006 warnings

* Address dotnet format CA1816 warnings

* Address or silence dotnet format CA2208 warnings

* Address or silence dotnet format CA1806 and a few CA1854 warnings

* Address dotnet format CA2211 warnings

* Address dotnet format CA1822 warnings

* Address or silence dotnet format CA1069 warnings

* Make dotnet format succeed in style mode

* Address or silence dotnet format CA2211 warnings

* Address review comments

* Address dotnet format CA2208 warnings properly

* Make ProcessResult readonly

* Address most dotnet format whitespace warnings

* Apply dotnet format whitespace formatting

A few of them have been manually reverted and the corresponding warning was silenced

* Add previously silenced warnings back

I have no clue how these disappeared

* Revert formatting changes for while and for-loops

* Format if-blocks correctly

* Run dotnet format style after rebase

* Run dotnet format whitespace after rebase

* Run dotnet format style after rebase

* Run dotnet format analyzers after rebase

* Run dotnet format after rebase and remove unused usings

- analyzers
- style
- whitespace

* Disable 'prefer switch expression' rule

* Add comments to disabled warnings

* Fix a few disabled warnings

* Fix naming rule violation, Convert shader properties to auto-property and convert values to const

* Simplify properties and array initialization, Use const when possible, Remove trailing commas

* Start working on disabled warnings

* Fix and silence a few dotnet-format warnings again

* Run dotnet format after rebase

* Use using declaration instead of block syntax

* Address IDE0251 warnings

* Address a few disabled IDE0060 warnings

* Silence IDE0060 in .editorconfig

* Revert "Simplify properties and array initialization, Use const when possible, Remove trailing commas"

This reverts commit 9462e4136c0a2100dc28b20cf9542e06790aa67e.

* dotnet format whitespace after rebase

* First dotnet format pass

* Fix naming rule violations

* Fix typo

* Add trailing commas, use targeted new and use array initializer

* Fix build issues

* Fix remaining build issues

* Remove SuppressMessage for CA1069 where possible

* Address dotnet format issues

* Address formatting issues

Co-authored-by: Ac_K <acoustik666@gmail.com>

* Add GetHashCode implementation for RenderingSurfaceInfo

* Explicitly silence CA1822 for every affected method in Syscall

* Address formatting issues in Demangler.cs

* Address review feedback

Co-authored-by: Ac_K <acoustik666@gmail.com>

* Revert marking service methods as static

* Next dotnet format pass

* Address review feedback

---------

Co-authored-by: Ac_K <acoustik666@gmail.com>

src/Ryujinx.HLE/HOS/Services/Time/ITimeServiceManager.cs

@@ -13,12 +13,12 @@ namespace Ryujinx.HLE.HOS.Services.Time
     [Service("time:m")] // 9.0.0+
     class ITimeServiceManager : IpcService
     {
-        private TimeManager _timeManager;
-        private int         _automaticCorrectionEvent;
+        private readonly TimeManager _timeManager;
+        private int _automaticCorrectionEvent;
 
         public ITimeServiceManager(ServiceCtx context)
         {
-            _timeManager              = TimeManager.Instance;
+            _timeManager = TimeManager.Instance;
             _automaticCorrectionEvent = 0;
         }
 
@@ -62,11 +62,11 @@ namespace Ryujinx.HLE.HOS.Services.Time
         // SetupStandardSteadyClock(nn::util::Uuid clock_source_id, nn::TimeSpanType setup_value,  nn::TimeSpanType internal_offset,  nn::TimeSpanType test_offset, bool is_rtc_reset_detected)
         public ResultCode SetupStandardSteadyClock(ServiceCtx context)
         {
-            UInt128      clockSourceId      = context.RequestData.ReadStruct<UInt128>();
-            TimeSpanType setupValue         = context.RequestData.ReadStruct<TimeSpanType>();
-            TimeSpanType internalOffset     = context.RequestData.ReadStruct<TimeSpanType>();
-            TimeSpanType testOffset         = context.RequestData.ReadStruct<TimeSpanType>();
-            bool         isRtcResetDetected = context.RequestData.ReadBoolean();
+            UInt128 clockSourceId = context.RequestData.ReadStruct<UInt128>();
+            TimeSpanType setupValue = context.RequestData.ReadStruct<TimeSpanType>();
+            TimeSpanType internalOffset = context.RequestData.ReadStruct<TimeSpanType>();
+            TimeSpanType testOffset = context.RequestData.ReadStruct<TimeSpanType>();
+            bool isRtcResetDetected = context.RequestData.ReadBoolean();
 
             ITickSource tickSource = context.Device.System.TickSource;
 
@@ -80,7 +80,7 @@ namespace Ryujinx.HLE.HOS.Services.Time
         public ResultCode SetupStandardLocalSystemClock(ServiceCtx context)
         {
             SystemClockContext clockContext = context.RequestData.ReadStruct<SystemClockContext>();
-            long               posixTime    = context.RequestData.ReadInt64();
+            long posixTime = context.RequestData.ReadInt64();
 
             ITickSource tickSource = context.Device.System.TickSource;
 
@@ -93,8 +93,8 @@ namespace Ryujinx.HLE.HOS.Services.Time
         // SetupStandardNetworkSystemClock(nn::time::SystemClockContext context, nn::TimeSpanType sufficient_accuracy)
         public ResultCode SetupStandardNetworkSystemClock(ServiceCtx context)
         {
-            SystemClockContext clockContext       = context.RequestData.ReadStruct<SystemClockContext>();
-            TimeSpanType       sufficientAccuracy = context.RequestData.ReadStruct<TimeSpanType>();
+            SystemClockContext clockContext = context.RequestData.ReadStruct<SystemClockContext>();
+            TimeSpanType sufficientAccuracy = context.RequestData.ReadStruct<TimeSpanType>();
 
             _timeManager.SetupStandardNetworkSystemClock(clockContext, sufficientAccuracy);
 
@@ -122,10 +122,10 @@ namespace Ryujinx.HLE.HOS.Services.Time
         // SetupTimeZoneManager(nn::time::LocationName location_name, nn::time::SteadyClockTimePoint timezone_update_timepoint, u32 total_location_name_count, nn::time::TimeZoneRuleVersion timezone_rule_version, buffer<nn::time::TimeZoneBinary, 0x21> timezone_binary)
         public ResultCode SetupTimeZoneManager(ServiceCtx context)
         {
-            string               locationName            = StringUtils.ReadInlinedAsciiString(context.RequestData, 0x24);
+            string locationName = StringUtils.ReadInlinedAsciiString(context.RequestData, 0x24);
             SteadyClockTimePoint timeZoneUpdateTimePoint = context.RequestData.ReadStruct<SteadyClockTimePoint>();
-            uint                 totalLocationNameCount  = context.RequestData.ReadUInt32();
-            UInt128              timeZoneRuleVersion     = context.RequestData.ReadStruct<UInt128>();
+            uint totalLocationNameCount = context.RequestData.ReadUInt32();
+            UInt128 timeZoneRuleVersion = context.RequestData.ReadStruct<UInt128>();
 
             (ulong bufferPosition, ulong bufferSize) = context.Request.GetBufferType0x21();
 
@@ -133,10 +133,9 @@ namespace Ryujinx.HLE.HOS.Services.Time
 
             context.Memory.Read(bufferPosition, temp);
 
-            using (MemoryStream timeZoneBinaryStream = new MemoryStream(temp))
-            {
-                _timeManager.SetupTimeZoneManager(locationName, timeZoneUpdateTimePoint, totalLocationNameCount, timeZoneRuleVersion, timeZoneBinaryStream);
-            }
+            using MemoryStream timeZoneBinaryStream = new(temp);
+
+            _timeManager.SetupTimeZoneManager(locationName, timeZoneUpdateTimePoint, totalLocationNameCount, timeZoneRuleVersion, timeZoneBinaryStream);
 
             return ResultCode.Success;
         }