mirror of
				https://git.zaroz.cloud/nintendo-back-up/yuzu/yuzu-mainline.git
				synced 2025-03-21 01:53:15 +00:00 
			
		
		
		
	yuzu/configure_input*: Move data members after function declarations
The common pattern is to put the data members after the function interface where applicable.
This commit is contained in:
		
							parent
							
								
									ec7ea4ae96
								
							
						
					
					
						commit
						d67e88e59c
					
				@ -9,9 +9,10 @@
 | 
				
			|||||||
#include <memory>
 | 
					#include <memory>
 | 
				
			||||||
#include <optional>
 | 
					#include <optional>
 | 
				
			||||||
#include <string>
 | 
					#include <string>
 | 
				
			||||||
#include <unordered_map>
 | 
					
 | 
				
			||||||
#include <QDialog>
 | 
					#include <QDialog>
 | 
				
			||||||
#include <QKeyEvent>
 | 
					#include <QKeyEvent>
 | 
				
			||||||
 | 
					
 | 
				
			||||||
#include "common/param_package.h"
 | 
					#include "common/param_package.h"
 | 
				
			||||||
#include "core/settings.h"
 | 
					#include "core/settings.h"
 | 
				
			||||||
#include "input_common/main.h"
 | 
					#include "input_common/main.h"
 | 
				
			||||||
@ -36,6 +37,29 @@ public:
 | 
				
			|||||||
    void applyConfiguration();
 | 
					    void applyConfiguration();
 | 
				
			||||||
 | 
					
 | 
				
			||||||
private:
 | 
					private:
 | 
				
			||||||
 | 
					    void OnControllerButtonClick(int i);
 | 
				
			||||||
 | 
					
 | 
				
			||||||
 | 
					    /// Load configuration settings.
 | 
				
			||||||
 | 
					    void loadConfiguration();
 | 
				
			||||||
 | 
					    /// Restore all buttons to their default values.
 | 
				
			||||||
 | 
					    void restoreDefaults();
 | 
				
			||||||
 | 
					    /// Clear all input configuration
 | 
				
			||||||
 | 
					    void ClearAll();
 | 
				
			||||||
 | 
					
 | 
				
			||||||
 | 
					    /// Update UI to reflect current configuration.
 | 
				
			||||||
 | 
					    void updateButtonLabels();
 | 
				
			||||||
 | 
					
 | 
				
			||||||
 | 
					    /// Called when the button was pressed.
 | 
				
			||||||
 | 
					    void handleClick(QPushButton* button,
 | 
				
			||||||
 | 
					                     std::function<void(const Common::ParamPackage&)> new_input_setter,
 | 
				
			||||||
 | 
					                     InputCommon::Polling::DeviceType type);
 | 
				
			||||||
 | 
					
 | 
				
			||||||
 | 
					    /// Finish polling and configure input using the input_setter
 | 
				
			||||||
 | 
					    void setPollingResult(const Common::ParamPackage& params, bool abort);
 | 
				
			||||||
 | 
					
 | 
				
			||||||
 | 
					    /// Handle key press events.
 | 
				
			||||||
 | 
					    void keyPressEvent(QKeyEvent* event) override;
 | 
				
			||||||
 | 
					
 | 
				
			||||||
    std::unique_ptr<Ui::ConfigureInputPlayer> ui;
 | 
					    std::unique_ptr<Ui::ConfigureInputPlayer> ui;
 | 
				
			||||||
 | 
					
 | 
				
			||||||
    u8 player_index;
 | 
					    u8 player_index;
 | 
				
			||||||
@ -77,27 +101,4 @@ private:
 | 
				
			|||||||
 | 
					
 | 
				
			||||||
    std::array<QPushButton*, 4> controller_color_buttons;
 | 
					    std::array<QPushButton*, 4> controller_color_buttons;
 | 
				
			||||||
    std::array<QColor, 4> controller_colors;
 | 
					    std::array<QColor, 4> controller_colors;
 | 
				
			||||||
 | 
					 | 
				
			||||||
    void OnControllerButtonClick(int i);
 | 
					 | 
				
			||||||
 | 
					 | 
				
			||||||
    /// Load configuration settings.
 | 
					 | 
				
			||||||
    void loadConfiguration();
 | 
					 | 
				
			||||||
    /// Restore all buttons to their default values.
 | 
					 | 
				
			||||||
    void restoreDefaults();
 | 
					 | 
				
			||||||
    /// Clear all input configuration
 | 
					 | 
				
			||||||
    void ClearAll();
 | 
					 | 
				
			||||||
 | 
					 | 
				
			||||||
    /// Update UI to reflect current configuration.
 | 
					 | 
				
			||||||
    void updateButtonLabels();
 | 
					 | 
				
			||||||
 | 
					 | 
				
			||||||
    /// Called when the button was pressed.
 | 
					 | 
				
			||||||
    void handleClick(QPushButton* button,
 | 
					 | 
				
			||||||
                     std::function<void(const Common::ParamPackage&)> new_input_setter,
 | 
					 | 
				
			||||||
                     InputCommon::Polling::DeviceType type);
 | 
					 | 
				
			||||||
 | 
					 | 
				
			||||||
    /// Finish polling and configure input using the input_setter
 | 
					 | 
				
			||||||
    void setPollingResult(const Common::ParamPackage& params, bool abort);
 | 
					 | 
				
			||||||
 | 
					 | 
				
			||||||
    /// Handle key press events.
 | 
					 | 
				
			||||||
    void keyPressEvent(QKeyEvent* event) override;
 | 
					 | 
				
			||||||
};
 | 
					};
 | 
				
			||||||
 | 
				
			|||||||
@ -28,23 +28,6 @@ public:
 | 
				
			|||||||
    void applyConfiguration();
 | 
					    void applyConfiguration();
 | 
				
			||||||
 | 
					
 | 
				
			||||||
private:
 | 
					private:
 | 
				
			||||||
    std::unique_ptr<Ui::ConfigureMouseAdvanced> ui;
 | 
					 | 
				
			||||||
 | 
					 | 
				
			||||||
    /// This will be the the setting function when an input is awaiting configuration.
 | 
					 | 
				
			||||||
    std::optional<std::function<void(const Common::ParamPackage&)>> input_setter;
 | 
					 | 
				
			||||||
 | 
					 | 
				
			||||||
    std::array<QPushButton*, Settings::NativeMouseButton::NumMouseButtons> button_map;
 | 
					 | 
				
			||||||
    std::array<Common::ParamPackage, Settings::NativeMouseButton::NumMouseButtons> buttons_param;
 | 
					 | 
				
			||||||
 | 
					 | 
				
			||||||
    std::vector<std::unique_ptr<InputCommon::Polling::DevicePoller>> device_pollers;
 | 
					 | 
				
			||||||
 | 
					 | 
				
			||||||
    std::unique_ptr<QTimer> timeout_timer;
 | 
					 | 
				
			||||||
    std::unique_ptr<QTimer> poll_timer;
 | 
					 | 
				
			||||||
 | 
					 | 
				
			||||||
    /// A flag to indicate if keyboard keys are okay when configuring an input. If this is false,
 | 
					 | 
				
			||||||
    /// keyboard events are ignored.
 | 
					 | 
				
			||||||
    bool want_keyboard_keys = false;
 | 
					 | 
				
			||||||
 | 
					 | 
				
			||||||
    /// Load configuration settings.
 | 
					    /// Load configuration settings.
 | 
				
			||||||
    void loadConfiguration();
 | 
					    void loadConfiguration();
 | 
				
			||||||
    /// Restore all buttons to their default values.
 | 
					    /// Restore all buttons to their default values.
 | 
				
			||||||
@ -65,4 +48,21 @@ private:
 | 
				
			|||||||
 | 
					
 | 
				
			||||||
    /// Handle key press events.
 | 
					    /// Handle key press events.
 | 
				
			||||||
    void keyPressEvent(QKeyEvent* event) override;
 | 
					    void keyPressEvent(QKeyEvent* event) override;
 | 
				
			||||||
 | 
					
 | 
				
			||||||
 | 
					    std::unique_ptr<Ui::ConfigureMouseAdvanced> ui;
 | 
				
			||||||
 | 
					
 | 
				
			||||||
 | 
					    /// This will be the the setting function when an input is awaiting configuration.
 | 
				
			||||||
 | 
					    std::optional<std::function<void(const Common::ParamPackage&)>> input_setter;
 | 
				
			||||||
 | 
					
 | 
				
			||||||
 | 
					    std::array<QPushButton*, Settings::NativeMouseButton::NumMouseButtons> button_map;
 | 
				
			||||||
 | 
					    std::array<Common::ParamPackage, Settings::NativeMouseButton::NumMouseButtons> buttons_param;
 | 
				
			||||||
 | 
					
 | 
				
			||||||
 | 
					    std::vector<std::unique_ptr<InputCommon::Polling::DevicePoller>> device_pollers;
 | 
				
			||||||
 | 
					
 | 
				
			||||||
 | 
					    std::unique_ptr<QTimer> timeout_timer;
 | 
				
			||||||
 | 
					    std::unique_ptr<QTimer> poll_timer;
 | 
				
			||||||
 | 
					
 | 
				
			||||||
 | 
					    /// A flag to indicate if keyboard keys are okay when configuring an input. If this is false,
 | 
				
			||||||
 | 
					    /// keyboard events are ignored.
 | 
				
			||||||
 | 
					    bool want_keyboard_keys = false;
 | 
				
			||||||
};
 | 
					};
 | 
				
			||||||
 | 
				
			|||||||
		Loading…
	
		Reference in New Issue
	
	Block a user