Lioncash 
							
						 
					 
					
						
						
						
						
							
						
						
							cfc9d92b38 
							
						 
					 
					
						
						
							
							yuzu/software_keyboard: Remove unnecessary GetStatus() member function  
						
						 
						
						... 
						
						
						
						Like with the profile selection dialog, we can just use the result of
QDialog's exec() function to determine whether or not a dialog was
accepted. 
						
					 
					
						2019-05-29 00:56:45 -04:00  
					
					
						 
						
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Lioncash 
							
						 
					 
					
						
						
						
						
							
						
						
							802dd3cc95 
							
						 
					 
					
						
						
							
							profile_select: Remove unnecessary GetStatus() member function  
						
						 
						
						... 
						
						
						
						This behavior is already provided by the built-in exec() function. We
just need to check the return value of it. 
						
					 
					
						2019-05-29 00:56:41 -04:00  
					
					
						 
						
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Lioncash 
							
						 
					 
					
						
						
						
						
							
						
						
							139301c5a1 
							
						 
					 
					
						
						
							
							profile_select: Return int instead of u32 for GetIndex()  
						
						 
						
						... 
						
						
						
						Qt uses a signed value to represent indices. We should follow this
convention where applicable to avoid unnecessary sign-conversion
warnings, as well as making it easier to interoperate with other aspects
of Qt.
While we're at it, we can also make a sign-conversion explicit. 
						
					 
					
						2019-05-29 00:29:09 -04:00  
					
					
						 
						
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Lioncash 
							
						 
					 
					
						
						
						
						
							
						
						
							8bbe930fac 
							
						 
					 
					
						
						
							
							core/core: Remove unnecessary includes  
						
						 
						
						... 
						
						
						
						The contents of these includes aren't used anywhere in this translation
unit. 
						
					 
					
						2019-05-29 00:00:27 -04:00  
					
					
						 
						
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Lioncash 
							
						 
					 
					
						
						
						
						
							
						
						
							c6f05b586f 
							
						 
					 
					
						
						
							
							yuzu_cmd/yuzu: Correct formatting specifier  
						
						 
						
						... 
						
						
						
						Amends the formatting specifier to obey libfmt. Prevents the application
from terminating due to a formatting issue in the error case. 
						
					 
					
						2019-05-28 22:28:46 -04:00  
					
					
						 
						
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Lioncash 
							
						 
					 
					
						
						
						
						
							
						
						
							84a8fb9264 
							
						 
					 
					
						
						
							
							core/loader: Remove LoadKernelSystemMode  
						
						 
						
						... 
						
						
						
						This is a hold-over from Citra and doesn't apply to yuzu. 
						
					 
					
						2019-05-28 22:28:44 -04:00  
					
					
						 
						
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Lioncash 
							
						 
					 
					
						
						
						
						
							
						
						
							b1a4ab2ccc 
							
						 
					 
					
						
						
							
							core/telemetry_session: Remove unnecessary web service nulling out in destructor  
						
						 
						
						... 
						
						
						
						This will automatically occur when the backend instance goes out of
scope at the end of the destructor's execution. 
						
					 
					
						2019-05-28 22:28:18 -04:00  
					
					
						 
						
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Lioncash 
							
						 
					 
					
						
						
						
						
							
						
						
							215fd82738 
							
						 
					 
					
						
						
							
							core/telemetry_session: Remove usages of the global system accessor  
						
						 
						
						... 
						
						
						
						Makes the dependency explicit in the TelemetrySession's interface
instead of making it a hidden dependency.
This also revealed a hidden issue with the way the telemetry session was
being initialized. It was attempting to retrieve the app loader and log
out title-specific information. However, this isn't always guaranteed to
be possible.
During the initialization phase, everything is being constructed. It
doesn't mean an actual title has been selected. This is what the Load()
function is for. This potentially results in dead code paths involving
the app loader. Instead, we explicitly add this information when we know
the app loader instance is available. 
						
					 
					
						2019-05-28 22:28:15 -04:00  
					
					
						 
						
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Lioncash 
							
						 
					 
					
						
						
						
						
							
						
						
							05af9d915c 
							
						 
					 
					
						
						
							
							core/telemetry_session: Explicitly delete copy and move constructors  
						
						 
						
						... 
						
						
						
						NonCopyable is misleading here. It also makes the class non-moveable as
well, so we can be explicit about this. 
						
					 
					
						2019-05-28 21:07:38 -04:00  
					
					
						 
						
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Lioncash 
							
						 
					 
					
						
						
						
						
							
						
						
							2fb3b9b951 
							
						 
					 
					
						
						
							
							core/telemetry_session: Remove unused include  
						
						 
						
						
						
					 
					
						2019-05-28 20:56:22 -04:00  
					
					
						 
						
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								bunnei 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							cfd885163f 
							
						 
					 
					
						
						
							
							Merge pull request  #2519  from lioncash/sign  
						
						 
						
						... 
						
						
						
						loader/nso, core/core_timing_util: Silence sign-comparison warning 
						
					 
					
						2019-05-27 12:26:17 -04:00  
					
					
						 
						
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								bunnei 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							2eb4d27c48 
							
						 
					 
					
						
						
							
							Merge pull request  #2524  from ReinUsesLisp/fixup-extension  
						
						 
						
						... 
						
						
						
						gl_shader_gen: Always declare extensions after the version declaration 
						
					 
					
						2019-05-27 12:25:59 -04:00  
					
					
						 
						
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								ReinUsesLisp 
							
						 
					 
					
						
						
						
						
							
						
						
							21c0b4dec8 
							
						 
					 
					
						
						
							
							gl_device: Add commentary to AOFFI unit test source code  
						
						 
						
						... 
						
						
						
						The intention behind this commit is to hint someone inspecting an
apitrace dump to ignore this ill-formed GLSL code. 
						
					 
					
						2019-05-27 00:55:57 -03:00  
					
					
						 
						
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								ReinUsesLisp 
							
						 
					 
					
						
						
						
						
							
						
						
							84928e6d67 
							
						 
					 
					
						
						
							
							gl_shader_gen: Always declare extensions after the version declaration  
						
						 
						
						... 
						
						
						
						This addresses a bug on geometry shaders where code was being written
before all #extension declarations were done. Ref to #2523  
						
					 
					
						2019-05-27 00:51:35 -03:00  
					
					
						 
						
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Zach Hilman 
							
						 
					 
					
						
						
						
						
							
						
						
							46e2ca5475 
							
						 
					 
					
						
						
							
							game_list_worker: Add better error handling to caching  
						
						 
						
						
						
					 
					
						2019-05-26 17:14:09 -04:00  
					
					
						 
						
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Zach Hilman 
							
						 
					 
					
						
						
						
						
							
						
						
							944c07ac7d 
							
						 
					 
					
						
						
							
							yuzu: Clear partial/full game list cache when data is updated  
						
						 
						
						
						
					 
					
						2019-05-26 15:12:12 -04:00  
					
					
						 
						
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Zach Hilman 
							
						 
					 
					
						
						
						
						
							
						
						
							f95bdb5088 
							
						 
					 
					
						
						
							
							game_list: Implement caching for game list  
						
						 
						
						... 
						
						
						
						Preserves list of add ons and the icon, which are the two costliest parts of game list population. 
						
					 
					
						2019-05-26 15:12:12 -04:00  
					
					
						 
						
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Zach Hilman 
							
						 
					 
					
						
						
						
						
							
						
						
							180f22f17e 
							
						 
					 
					
						
						
							
							ui_settings: Add option to cache game list  
						
						 
						
						
						
					 
					
						2019-05-26 15:12:12 -04:00  
					
					
						 
						
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								ReinUsesLisp 
							
						 
					 
					
						
						
						
						
							
						
						
							37eaf39b44 
							
						 
					 
					
						
						
							
							emu_window: Pass OnMinimalClientAreaChangeRequest argument by copy  
						
						 
						
						... 
						
						
						
						There's no performance improvement in passing an unsigned pair by
reference. 
						
					 
					
						2019-05-26 00:54:13 -03:00  
					
					
						 
						
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								bunnei 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							90c9d703ba 
							
						 
					 
					
						
						
							
							Merge pull request  #2516  from lioncash/label  
						
						 
						
						... 
						
						
						
						renderer_opengl/utils: Use a std::string_view with LabelGLObject() 
						
					 
					
						2019-05-25 23:01:25 -04:00  
					
					
						 
						
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								bunnei 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							bb248a2710 
							
						 
					 
					
						
						
							
							Merge pull request  #2509  from lioncash/aoc  
						
						 
						
						... 
						
						
						
						service/aoc_u: Minor cleanup 
						
					 
					
						2019-05-25 23:00:12 -04:00  
					
					
						 
						
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								bunnei 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							f97e206348 
							
						 
					 
					
						
						
							
							Merge pull request  #2511  from lioncash/file-str  
						
						 
						
						... 
						
						
						
						common/file_util: Minor cleanup 
						
					 
					
						2019-05-25 22:59:16 -04:00  
					
					
						 
						
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								bunnei 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							91300bdfb2 
							
						 
					 
					
						
						
							
							Merge pull request  #2517  from lioncash/hotkey  
						
						 
						
						... 
						
						
						
						configure_hotkeys: Minor cleanup 
						
					 
					
						2019-05-25 22:58:46 -04:00  
					
					
						 
						
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Lioncash 
							
						 
					 
					
						
						
						
						
							
						
						
							0fa039d8d0 
							
						 
					 
					
						
						
							
							core_timing_util: Silence sign-comparison warnings  
						
						 
						
						... 
						
						
						
						We can just make the conversion explicit instead of implicit here to
silence -Wsign-compare warnings. 
						
					 
					
						2019-05-25 17:01:18 -04:00  
					
					
						 
						
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Lioncash 
							
						 
					 
					
						
						
						
						
							
						
						
							e5159cfb84 
							
						 
					 
					
						
						
							
							loader/nso: Silence sign-comparison warning  
						
						 
						
						... 
						
						
						
						This was previously performing a size_t == int comparison. Silences a
-Wsign-compare warning. 
						
					 
					
						2019-05-25 16:53:33 -04:00  
					
					
						 
						
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								ReinUsesLisp 
							
						 
					 
					
						
						
						
						
							
						
						
							4b80dd23a4 
							
						 
					 
					
						
						
							
							yuzu_cmd: Split emu_window OpenGL implementation into its own file  
						
						 
						
						
						
					 
					
						2019-05-25 17:47:13 -03:00  
					
					
						 
						
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Lioncash 
							
						 
					 
					
						
						
						
						
							
						
						
							88cd5e888e 
							
						 
					 
					
						
						
							
							configure_hotkeys: Remove unnecessary Settings::Apply() call  
						
						 
						
						... 
						
						
						
						Nothing from the hotkeys dialog relies on this call occurring, and is
already called from the dialog that calls applyConfiguration(). 
						
					 
					
						2019-05-25 04:34:54 -04:00  
					
					
						 
						
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Lioncash 
							
						 
					 
					
						
						
						
						
							
						
						
							6640f631e2 
							
						 
					 
					
						
						
							
							configure_hotkeys: Tidy up key sequence conflict error string  
						
						 
						
						... 
						
						
						
						Avoids mentioning the user and formalizes the error itself. 
						
					 
					
						2019-05-25 04:25:11 -04:00  
					
					
						 
						
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Lioncash 
							
						 
					 
					
						
						
						
						
							
						
						
							d61199721d 
							
						 
					 
					
						
						
							
							configure_hotkeys: Change critical error dialog into a warning dialog  
						
						 
						
						... 
						
						
						
						critical() is intended for critical/fatal errors that threaten the
overall stability of an application. A user entering a conflicting key
sequence is neither of those. 
						
					 
					
						2019-05-25 04:08:18 -04:00  
					
					
						 
						
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Lioncash 
							
						 
					 
					
						
						
						
						
							
						
						
							ef3c0f54d0 
							
						 
					 
					
						
						
							
							configure_hotkeys: Move conflict detection logic to IsUsedKey()  
						
						 
						
						... 
						
						
						
						We don't need to extract the entire set of hotkeys into a list and then
iterate through it. We can traverse the list and early-exit if we're
able to. 
						
					 
					
						2019-05-25 04:08:13 -04:00  
					
					
						 
						
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Lioncash 
							
						 
					 
					
						
						
						
						
							
						
						
							c03fb00ac1 
							
						 
					 
					
						
						
							
							configure_hotkeys: Remove unused EmitHotkeysChanged()  
						
						 
						
						... 
						
						
						
						1. This is something that should be solely emitted by the hotkey dialog
itself
2. This is functionally unused, given there's nothing listening for the
signal. 
						
					 
					
						2019-05-25 04:08:07 -04:00  
					
					
						 
						
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Lioncash 
							
						 
					 
					
						
						
						
						
							
						
						
							5d645c6dd9 
							
						 
					 
					
						
						
							
							sequence_dialog: Reorganize the constructor  
						
						 
						
						... 
						
						
						
						The previous code was all "smushed" together wasn't really grouped
together that well.
This spaces things out and separates them by relation to one another,
making it easier to visually parse the individual sections of code that
make up the constructor. 
						
					 
					
						2019-05-25 04:08:02 -04:00  
					
					
						 
						
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Lioncash 
							
						 
					 
					
						
						
						
						
							
						
						
							9218e347cd 
							
						 
					 
					
						
						
							
							sequence_dialog: Remove unnecessary horizontal specifier  
						
						 
						
						... 
						
						
						
						QDialogButtonBoxes are horizontal by default. 
						
					 
					
						2019-05-25 04:07:56 -04:00  
					
					
						 
						
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Lioncash 
							
						 
					 
					
						
						
						
						
							
						
						
							5a4564bd8e 
							
						 
					 
					
						
						
							
							renderer_opengl/utils: Use a std::string_view with LabelGLObject()  
						
						 
						
						... 
						
						
						
						Uses a std::string_view instead of a std::string, given the pointed to
string isn't modified and is only used in a formatting operation.
This is nice because a few usages directly supply a string literal to
the function, allowing these usages to otherwise not heap allocate,
unlike the std::string overloads.
While we're at it, we can combine the address formatting into a single
formatting call. 
						
					 
					
						2019-05-24 23:50:10 -04:00  
					
					
						 
						
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								bunnei 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							e86d2e2e5b 
							
						 
					 
					
						
						
							
							Merge pull request  #2513  from lioncash/string  
						
						 
						
						... 
						
						
						
						yuzu/main: Specify string conversions explicitly 
						
					 
					
						2019-05-24 22:46:10 -04:00  
					
					
						 
						
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								bunnei 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							68c9c9222d 
							
						 
					 
					
						
						
							
							Merge pull request  #2358  from ReinUsesLisp/parallel-shader  
						
						 
						
						... 
						
						
						
						gl_shader_cache: Use shared contexts to build shaders in parallel at boot 
						
					 
					
						2019-05-24 22:42:08 -04:00  
					
					
						 
						
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Lioncash 
							
						 
					 
					
						
						
						
						
							
						
						
							d623e38d18 
							
						 
					 
					
						
						
							
							yuzu/configuration/configure_graphics: Eliminate type narrowing in a connect call  
						
						 
						
						... 
						
						
						
						A checkbox is able to be tri-state, giving it three possible activity
types, so in the connect call here, it would actually be truncating an
int into a bool.
Instead, we can just listen on the toggled() signal, which passes along
a bool, not an int. 
						
					 
					
						2019-05-24 22:24:40 -04:00  
					
					
						 
						
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Lioncash 
							
						 
					 
					
						
						
						
						
							
						
						
							3c0280cf66 
							
						 
					 
					
						
						
							
							yuzu/CMakeLists: Disable implicit QString conversions  
						
						 
						
						... 
						
						
						
						Now that all of our code is compilable with implicit QString
conversions, we can enforce it at compile-time by disabling them. 
						
					 
					
						2019-05-24 21:31:01 -04:00  
					
					
						 
						
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Lioncash 
							
						 
					 
					
						
						
						
						
							
						
						
							bb06b98d81 
							
						 
					 
					
						
						
							
							yuzu/applets/software_keyboard: Remove unused assert header  
						
						 
						
						... 
						
						
						
						This isn't actually used anywhere, so it can be removed. 
						
					 
					
						2019-05-24 21:27:13 -04:00  
					
					
						 
						
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Lioncash 
							
						 
					 
					
						
						
						
						
							
						
						
							16bf791939 
							
						 
					 
					
						
						
							
							yuzu/applets/software_keyboard: std::move argument in MainWindowFinishedText()  
						
						 
						
						... 
						
						
						
						Given the std::optional can contain an object type that heap allocates,
we can use std::move to avoid an unnecessary copy/allocation from
occurring. 
						
					 
					
						2019-05-24 21:27:12 -04:00  
					
					
						 
						
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Lioncash 
							
						 
					 
					
						
						
						
						
							
						
						
							b3d7180164 
							
						 
					 
					
						
						
							
							yuzu/applets/software_keyboard: Resolve sign mismatch comparison  
						
						 
						
						... 
						
						
						
						Qt uses a signed value to represent container sizes, so this was causing
a sign mismatch warning. 
						
					 
					
						2019-05-24 21:27:12 -04:00  
					
					
						 
						
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Lioncash 
							
						 
					 
					
						
						
						
						
							
						
						
							cf9cc41478 
							
						 
					 
					
						
						
							
							yuzu/applets/software_keyboard: Specify string conversions explicitly  
						
						 
						
						... 
						
						
						
						Allows the software keyboard applet code to compile with implicit string
conversions disabled. 
						
					 
					
						2019-05-24 21:27:12 -04:00  
					
					
						 
						
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Lioncash 
							
						 
					 
					
						
						
						
						
							
						
						
							f5d416e071 
							
						 
					 
					
						
						
							
							yuzu/applets/error: Specify string conversions explicitly  
						
						 
						
						... 
						
						
						
						Allows the error applet to build successfully with implicit string
conversions disabled. 
						
					 
					
						2019-05-24 21:27:12 -04:00  
					
					
						 
						
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Lioncash 
							
						 
					 
					
						
						
						
						
							
						
						
							6f2a8fbb13 
							
						 
					 
					
						
						
							
							yuzu/main: Specify string conversions where applicable  
						
						 
						
						
						
					 
					
						2019-05-24 21:27:09 -04:00  
					
					
						 
						
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								bunnei 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							1a2d90ab09 
							
						 
					 
					
						
						
							
							Merge pull request  #2485  from ReinUsesLisp/generic-memory  
						
						 
						
						... 
						
						
						
						shader/memory: Implement generic memory stores and loads (ST and LD) 
						
					 
					
						2019-05-24 18:24:26 -04:00  
					
					
						 
						
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								bunnei 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							59f110ef31 
							
						 
					 
					
						
						
							
							Merge pull request  #2504  from lioncash/config  
						
						 
						
						... 
						
						
						
						yuzu/configuration/config: Specify string conversions explicitly 
						
					 
					
						2019-05-24 18:23:58 -04:00  
					
					
						 
						
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								bunnei 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							d4f8fe24d9 
							
						 
					 
					
						
						
							
							Merge pull request  #2489  from FearlessTobi/port-4716  
						
						 
						
						... 
						
						
						
						Port citra-emu/citra#4716 : "HLE/IPC: HLEContext can memorize the client thread and use it for SleepClientThread" 
						
					 
					
						2019-05-24 18:23:15 -04:00  
					
					
						 
						
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								bunnei 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							c70404eab5 
							
						 
					 
					
						
						
							
							Merge pull request  #2505  from ReinUsesLisp/glad-update  
						
						 
						
						... 
						
						
						
						externals: Update glad to support OpenGL 4.6 compatibility profile 
						
					 
					
						2019-05-24 18:23:04 -04:00  
					
					
						 
						
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Lioncash 
							
						 
					 
					
						
						
						
						
							
						
						
							e7ab0e9127 
							
						 
					 
					
						
						
							
							common/file_util: Remove unnecessary return at end of void StripTailDirSlashes()  
						
						 
						
						... 
						
						
						
						While we're at it, also invert the conditional into a guard clause. 
						
					 
					
						2019-05-23 14:33:29 -04:00  
					
					
						 
						
							
							
							 
						
					 
				 
			
				
					
						
							
							
								 
								Lioncash 
							
						 
					 
					
						
						
						
						
							
						
						
							11e9bee91d 
							
						 
					 
					
						
						
							
							common/file_util: Make GetCurrentDir() return a std::optional  
						
						 
						
						... 
						
						
						
						nullptr was being returned in the error case, which, at a glance may
seem perfectly OK... until you realize that std::string has the
invariant that it may not be constructed from a null pointer. This
means that if this error case was ever hit, then the application would
most likely crash from a thrown exception in std::string's constructor.
Instead, we can change the function to return an optional value,
indicating if a failure occurred. 
						
					 
					
						2019-05-23 14:24:13 -04:00