7243 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
bunnei	cbf43225a9	Merge pull request #704 from lioncash/string ... string_util: Remove AsciiToHex()	2018-07-19 08:46:40 -07:00
bunnei	f1d7486eac	Merge pull request #703 from lioncash/const ... savedata_factory: Make SaveDataDescriptor's DebugInfo() function a const member function	2018-07-19 08:46:15 -07:00
bunnei	b0334af05b	Merge pull request #702 from lioncash/initialize ... partition_filesystem: Ensure all class members of PartitionFilesystem are initialized	2018-07-19 08:45:54 -07:00
bunnei	1bf7ae79c8	Merge pull request #701 from lioncash/moving ... content_archive: Minor changes	2018-07-19 08:41:42 -07:00
Lioncash	dc35c3f9d7	nvdrv: Take std::string by const reference in GetDevice() ... This is only ever used as a lookup into the device map, so we don't need to take the std::string instance by value here.	2018-07-19 11:40:36 -04:00
Lioncash	af2698dcea	hle_ipc: Amend usage of buffer_index within one of HLERequestContext's WriteBuffer() overloads ... Previously, the buffer_index parameter was unused, causing all writes to use the buffer index of zero, which is not necessarily what is wanted all the time. Thankfully, all current usages don't use a buffer index other than zero, so this just prevents a bug before it has a chance to spring.	2018-07-19 11:10:16 -04:00
Lioncash	6c1ba02e0c	fsp_srv: Remove unnecessary vector construction in IFile's Write() function ... We can avoid constructing a std::vector here by simply passing a pointer to the original data and the size of the copy we wish to perform to the backend's Write() function instead, avoiding copying the data where it's otherwise not needed.	2018-07-19 11:01:07 -04:00
Lioncash	3e9b79e088	fsp_srv: Remove unnecessary std::vector construction in IDirectory's Read() function ... We were using a second std::vector as a buffer to convert another std::vector's data into a byte sequence, however we can just use pointers to the original data and use them directly with WriteBuffer, which avoids copying the data at all into a separate std::vector. We simply cast the pointers to u8* (which is allowed by the standard, given std::uint8_t is an alias for unsigned char on platforms that we support).	2018-07-19 10:46:54 -04:00
bunnei	758c357868	Merge pull request #699 from lioncash/vfs ... vfs: Deduplicate accumulation code in VfsDirectory's GetSize()	2018-07-19 07:38:45 -07:00
bunnei	87053fb3b8	Merge pull request #697 from bunnei/disable-depth-cull ... gl_state: Temporarily disable culling and depth test.	2018-07-19 07:38:00 -07:00
Lioncash	5da4c78c6a	filesystem: std::move VirtualDir instance in VfsDirectoryServiceWrapper's constructor ... Avoids unnecessary atomic reference count incrementing and decrementing	2018-07-19 10:34:11 -04:00
Lioncash	abbf038191	filesystem: Use std::string's empty() function instead of comparing against a literal ... This is simply a basic value check as opposed to potentially doing string based operations (unlikely, but still, avoiding it is free).	2018-07-19 10:32:23 -04:00
Lioncash	2cc0ef83cf	filesystem: Remove pragma disabling global optimizations ... This was just an artifact missed during PR review.	2018-07-19 10:30:53 -04:00
Lioncash	f317080f40	fsp_srv: Make IStorage constructor explicit ... Prevents implicit conversions.	2018-07-19 10:04:16 -04:00
Lioncash	910ad2e110	fsp_srv: Add missing includes ... Gets rid of relying on indirect inclusions.	2018-07-19 10:03:17 -04:00
Lioncash	6be342118a	fsp_srv: Resolve sign-mismatch warnings in assertion comparisons	2018-07-19 09:58:32 -04:00
Lioncash	d6e9b96e2f	fsp_srv: Respect write length in Write() ... Previously we were just copying the data whole-sale, even if the length was less than the total data size. This effectively makes the actual_data vector useless, which is likely not intended. Instead, amend this to only copy the given length amount of data. At the same time, we can avoid zeroing out the data before using it by passing iterators to the constructor instead of a size.	2018-07-19 09:57:48 -04:00
Lioncash	5c47ea1a4e	common/swap: Remove unnecessary const on return value of swap()	2018-07-19 09:35:54 -04:00
Lioncash	0a868641fa	common/swap: Use static_cast where applicable	2018-07-19 09:35:13 -04:00
Lioncash	1edf4dd7ef	common/swap: Use using aliases where applicable	2018-07-19 09:32:13 -04:00
Lioncash	9128271292	common/common_funcs: Remove unused rotation functions ... These are unused and essentially don't provide much benefit either. If we ever need rotation functions, these can be introduced in a way that they don't sit in a common_* header and require a bunch of ifdefing to simply be available	2018-07-19 09:21:23 -04:00
Lioncash	e0b8a35937	common/misc: Deduplicate code in GetLastErrorMsg() ... Android and macOS have supported thread_local for quite a while, but most importantly is that we don't even really need it. Instead of using a thread-local buffer, we can just return a non-static buffer as a std::string, avoiding the need for that quality entirely.	2018-07-19 09:15:38 -04:00
Lioncash	ef03d0178a	externals: Update Xbyak to 5.65 ... Keeps the JIT assembler library up to date and ensures we don't run into any issues that may have been resolved.	2018-07-19 08:38:07 -04:00
Lioncash	25f997097d	externals: Update catch to v2.2.3 ... Keeps the unit-testing library up to date.	2018-07-19 08:33:06 -04:00
Lioncash	63e64f0131	file_util: return string by const reference for GetExeDirectory() ... This disallows modifying the internal string buffer (which shouldn't be modified anyhow).	2018-07-19 01:27:29 -04:00
bunnei	cd4fca8447	Merge pull request #700 from bunnei/update-dynarmic ... externals: Update dynarmic to 5a91c94.	2018-07-18 22:01:39 -07:00
Lioncash	33fbcb45a7	string_util: Remove AsciiToHex() ... Easy TODO	2018-07-18 23:57:15 -04:00
bunnei	368e1d25be	Merge pull request #692 from lioncash/assign ... address_arbiter: Correct assignment within an assertion statement in WakeThreads()	2018-07-18 20:56:28 -07:00
bunnei	85421f3406	Merge pull request #690 from lioncash/move ... core/memory, core/hle/kernel: Use std::move where applicable	2018-07-18 20:55:55 -07:00
Lioncash	88ba94e8a2	savedata_factory: Make SaveDataDescriptor's DebugInfo() function a const member function ... This function doesn't alter class state.	2018-07-18 23:50:07 -04:00
Lioncash	9abc5763b6	partition_filesystem: Ensure all class members of PartitionFilesystem are initialized ... Previously is_hfs and pfs_header members wouldn't be initialized in the constructor, as they were stored in locals instead. This would result in things like GetName() and PrintDebugInfo() behaving incorrectly. While we're at it, initialize the members to deterministic values as well, in case loading ever fails.	2018-07-18 23:45:22 -04:00
bunnei	cf30c4be22	gl_state: Temporarily disable culling and depth test.	2018-07-18 23:21:43 -04:00
Lioncash	4790bb907d	content_archive: Make IsDirectoryExeFS() take a shared_ptr as a const reference ... There's no need to take this by value when it's possible to avoid unnecessary copies entirely like this.	2018-07-18 23:19:28 -04:00
Lioncash	87a9bb392b	content_archive: Add missing standard includes	2018-07-18 23:18:59 -04:00
bunnei	522bd5b736	externals: Update dynarmic to 5a91c94.	2018-07-18 23:14:44 -04:00
Lioncash	0b566f43a1	content_archive: std::move VirtualFile in NCA's constructor ... Gets rid of unnecessary atomic reference count incrementing and decrementing.	2018-07-18 23:13:25 -04:00
Lioncash	5e626c774f	vfs: Deduplicate accumulation code in VfsDirectory's GetSize() ... We can just use a generic lambda to avoid writing the same thing twice.	2018-07-18 23:03:27 -04:00
bunnei	1371e2fb6a	Merge pull request #691 from lioncash/guard ... service/prepo: Add missing header guard	2018-07-18 19:46:14 -07:00
bunnei	b10905c8ae	Merge pull request #686 from lioncash/fmt ... externals: update fmt to version 5.1.0	2018-07-18 19:44:44 -07:00
Lioncash	55ab369043	loader/nro: Resolve sign mismatch warnings	2018-07-18 22:27:22 -04:00
Lioncash	1831b5ef62	loader/nso: Remove unnecessary vector resizes ... We can just initialize these vectors directly via their constructor.	2018-07-18 22:26:41 -04:00
Lioncash	e3a30ccc7c	loader/nso: Resolve sign mismatch warnings	2018-07-18 22:26:37 -04:00
bunnei	90ce935f3d	Merge pull request #688 from lioncash/comma ... vm_manager: Add missing commas to string literal array elements in GetMemoryStateName()	2018-07-18 18:59:09 -07:00
bunnei	3f93279047	Merge pull request #693 from lioncash/unused ... core/memory: Remove unused function GetSpecialHandlers() and an unused variable in ZeroBlock()	2018-07-18 18:57:13 -07:00
bunnei	49b0966003	Merge pull request #687 from lioncash/instance ... core: Don't construct instance of Core::System, just to access its live instance	2018-07-18 18:55:58 -07:00
bunnei	89f0acfd36	Merge pull request #680 from bunnei/fix-swizz ... decoders: Fix calc of swizzle image_width_in_gobs.	2018-07-18 18:55:37 -07:00
bunnei	d883d3b64f	Merge pull request #685 from lioncash/build ... hle/filesystem: Amend trace log in OpenSaveData() to compile in debug mode	2018-07-18 18:55:15 -07:00
bunnei	2975f7820e	Merge pull request #684 from lioncash/nonmember ... game_list: Make ContainsAllWords an internally linked non-member function	2018-07-18 18:55:00 -07:00
bunnei	b496a9eefe	decoders: Fix calc of swizzle image_width_in_gobs.	2018-07-18 21:42:52 -04:00
Zach Hilman	29aff8d5ab	Virtual Filesystem 2: Electric Boogaloo (#676) ... * Virtual Filesystem * Fix delete bug and documentate * Review fixes + other stuff * Fix puyo regression	2018-07-18 18:07:11 -07:00